Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16580 )
Change subject: wip KUDU-3149: don't block op registration on MM mutex ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16580/4/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16580/4/src/kudu/util/maintenance_manager.cc@302 PS4, Line 302: emplace > It looks like emplace is valid C++11 Right, the 'emplace' method signature assumes just a single element to add into the container, but here is a range. Anyways, we will see whether it's compilable or not :) -- To view, visit http://gerrit.cloudera.org:8080/16580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1b810f5b7ff6a22acc9b10b79ddffa8085c990 Gerrit-Change-Number: 16580 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 13 Oct 2020 18:26:30 +0000 Gerrit-HasComments: Yes
