Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 )
Change subject: Fix order of clearing openssl error and printing it ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16631/1//COMMIT_MSG Commit Message: PS1: What was the error we saw here? Is there any way to test this so we don't regress it in the future? http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc@248 PS1, Line 248: ERR_clear_error(); // in case it left anything on the queue. nit: Can you also note that it's important to call this before X509NameToString() and why? -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Oct 2020 21:45:35 +0000 Gerrit-HasComments: Yes
