Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 )
Change subject: [tserver] KUDU-2612: participant op RPC endpoint ...................................................................... Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/16814/3/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/16814/3/src/kudu/integration-tests/txn_participant-itest.cc@523 PS3, Line 523: TODO(awong): make repeated, idempotent return OK instead of an error. Yep, I guess it will be more robust that way. http://gerrit.cloudera.org:8080/#/c/16814/3/src/kudu/integration-tests/txn_participant-itest.cc@622 PS3, Line 622: Status nit for here and in other similar scenarios below: use auto? http://gerrit.cloudera.org:8080/#/c/16814/3/src/kudu/integration-tests/txn_participant-itest.cc@623 PS3, Line 623: ASSERT_TRUE(resp_error.IsIllegalState()); nit: add << s.ToString() just in case it fails http://gerrit.cloudera.org:8080/#/c/16814/3/src/kudu/integration-tests/txn_participant-itest.cc@648 PS3, Line 648: ASSERT_TRUE(resp_error.IsIllegalState()); nit: add << resp_error.ToString() -- To view, visit http://gerrit.cloudera.org:8080/16814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48895438ce67e453d235934ac560efe8415921b Gerrit-Change-Number: 16814 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Dec 2020 07:36:54 +0000 Gerrit-HasComments: Yes
