Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16876 )
Change subject: rpc: fix non-retriable error when starting up or shutting down ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/rpc/messenger.cc@382 PS1, Line 382: Status::ServiceUnavailable Now, when there is more detailed information on the state of the messenger, should we switch here to Status::NotFound() in case if state_ == kRunning? http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/server/rpc_server.cc@222 PS1, Line 222: messenger_->set_running(); What about RPC messenger at the client side? Should we toggle its state as well? -- To view, visit http://gerrit.cloudera.org:8080/16876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e2379de4cf632d257b93cd701d7c73cb2bbaed Gerrit-Change-Number: 16876 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Dec 2020 18:56:44 +0000 Gerrit-HasComments: Yes
