Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] Range specific hashing at table creation time. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/7/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16859/7/src/kudu/master/catalog_manager.cc@1722 PS7, Line 1722: for (int i = 0; i < req.range_hash_schemas_size(); i++) { : PartitionSchema::HashBucketSchemas hash_bucket_schemas; : RETURN_NOT_OK( : PartitionSchema::ExtractHashBucketSchemasFromPB(schema, : req.range_hash_schemas(i).hash_schemas(), : &hash_bucket_schemas)); : range_hash_schemas.emplace_back(std::move(hash_bucket_schemas)); : } Since the full functionality isn't complete, and since can lead to weird behavior until the feature is complete, let's guard this by an unsafe gflag, like FLAGS_enable_per_range_hash_schemas or somesuch. It'd be pretty bad if a newer client tried to send a request that led to unusable metadata. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 7 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Dec 2020 19:38:42 +0000 Gerrit-HasComments: Yes
