Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16903 )
Change subject: KUDU-1644 use range partition info for pruning ...................................................................... Patch Set 1: (4 comments) Overall looks pretty good. Thanks for following up here! http://gerrit.cloudera.org:8080/#/c/16903/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16903/1//COMMIT_MSG@9 PS1, Line 9: When pruning in-list predicate values, range partition can also be taken I can see this being particularly useful if range partitioning is defined per hour or per day, and querying specific times. I'm curious, has your use case been able to leverage this optimization yet? If so, I'd love to hear more about your workloads. http://gerrit.cloudera.org:8080/#/c/16903/1/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: http://gerrit.cloudera.org:8080/#/c/16903/1/src/kudu/common/scan_spec-test.cc@82 PS1, Line 82: schema nit: this is a "spec string" since it represents a scan spec, not a schema http://gerrit.cloudera.org:8080/#/c/16903/1/src/kudu/common/scan_spec-test.cc@584 PS1, Line 584: AddInPredicate<int8_t>(&spec, "a", { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 }); : AddInPredicate<int8_t>(&spec, "b", { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 }); So far, we have good test coverage for the cases where 'a' is pruned. Could we also add a case where both 'a' and 'b' are pruned, e.g. if 'a' is hash partitioned and 'b' is range partitioned? Similar to TestMultiHashKeyOneColumnInListHashPruning http://gerrit.cloudera.org:8080/#/c/16903/1/src/kudu/common/scan_spec-test.cc@601 PS1, Line 601: a Should this be "b"? -- To view, visit http://gerrit.cloudera.org:8080/16903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f14f543cffd44f090026f344c9b06af13ea2e10 Gerrit-Change-Number: 16903 Gerrit-PatchSet: 1 Gerrit-Owner: wangning <1994wangn...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 00:48:15 +0000 Gerrit-HasComments: Yes
