Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 )
Change subject: (wip) KUDU-2612: restrict TxnStatusManager calls to be made by the leader only ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc@725 PS3, Line 725: FLAGS_leader_failure_max_missed_heartbeat_periods = 1; : FLAGS_raft_heartbeat_interval_ms = 30; I'm curious: do this settings provide stable behavior under TSAN/ASAN? http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc@749 PS3, Line 749: (int t = 0; t < 5; t++) Any idea how many re-elections happen while these transaction are being started? In other words, maybe make every thread starting several transactions in succession, spaced by some interval (e.g., 3 * raft_heartbeat_interval_ms) for better coverage? http://gerrit.cloudera.org:8080/#/c/16648/3/src/kudu/integration-tests/txn_status_table-itest.cc@756 PS3, Line 756: ASSERT_OK(s); : ASSERT_TRUE(txn_status.has_user()); : ASSERT_STREQ(kUser, txn_status.user().c_str()); : ASSERT_TRUE(txn_status.has_state()); : ASSERT_EQ(TxnStatePB::OPEN, txn_status.state()); I'm curious how does this scenario behave when any of this fails? How to join the threads in such case? I remember one of the approaches to address that is either using CHECK instead of ASSERT, so the test crashes, or simply increment failure count and then report on those once every thread is complete. -- To view, visit http://gerrit.cloudera.org:8080/16648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a Gerrit-Change-Number: 16648 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 06 Jan 2021 19:12:35 +0000 Gerrit-HasComments: Yes
