Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16938 )
Change subject: [util] add a few new metrics in MaintenanceManager ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: PS2: Would be great to get some basic test coverage for our new metrics here. http://gerrit.cloudera.org:8080/#/c/16938/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16938/1/src/kudu/util/maintenance_manager.cc@395 PS1, Line 395: WAL > Yup, I'm going to do so. I'm also adding a few related metrics, like a his Nice! http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager_metrics.cc File src/kudu/util/maintenance_manager_metrics.cc: http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager_metrics.cc@26 PS2, Line 26: "Number of times when calling Prepare() on a maintenance " : "operation failed", nit: it might be worth mentioning why Prepare() might fail, e.g. if an op collides with another running instance of that op. -- To view, visit http://gerrit.cloudera.org:8080/16938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5420afd605f9bd22207af142b49e73336907486 Gerrit-Change-Number: 16938 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 01:55:58 +0000 Gerrit-HasComments: Yes
