Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16648 )
Change subject: KUDU-2612: restrict TxnStatusManager calls to be made by the leader only ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/integration-tests/txn_status_table-itest.cc@818 PS13, Line 818: // Make sure a re-election happens before the following read. Is this guaranteed to happen? If we need to change leadership, quiescing might be an approach. Look around for 'mutable_quiescing()' in some existing tests. http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/master/txn_manager-test.cc File src/kudu/master/txn_manager-test.cc: PS13: Why the changes in this file? http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/transactions/txn_status_manager.cc@214 PS13, Line 214: PREDICT_FALSE(!replica_status_.ok()) || : PREDICT_FALSE(FLAGS_txn_status_tablet_inject_uninitialized_leader_status_error) nit: wrap in a single PREDICT_FALSE http://gerrit.cloudera.org:8080/#/c/16648/13/src/kudu/transactions/txn_status_manager.cc@400 PS13, Line 400: !s.ok() || PREDICT_FALSE nit: maybe wrap the entire thing in PREDICT_FALSE instead of just the flag -- To view, visit http://gerrit.cloudera.org:8080/16648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42c1ad095dcb4bdffcbe0ecf9631a60bac208c2a Gerrit-Change-Number: 16648 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 29 Jan 2021 08:43:43 +0000 Gerrit-HasComments: Yes