Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17013 )
Change subject: KUDU-2612: follow up of commit c033487 ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: Code-Review+1 > > (1 comment) > > Thank you for addressing those comments from > https://gerrit.cloudera.org/#/c/16648/ > > This change looks good, but > TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances is still > failing. Right, I haven't got a chance to dig whether this is a test flakiness or not. So I will revert the disable change for now and address it in another patch tomorrow. As they don't need to be within the same one. Does this sound good to you? http://gerrit.cloudera.org:8080/#/c/17013/1/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/17013/1/src/kudu/integration-tests/txn_status_table-itest.cc@749 PS1, Line 749: 2 > In prior version it was 3, but I guess txn_id 2 works flawlessly as well he Yes. :) -- To view, visit http://gerrit.cloudera.org:8080/17013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ac5c1c123e33d60bc7c23dec015072d5c5ed9fd Gerrit-Change-Number: 17013 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Feb 2021 02:24:24 +0000 Gerrit-HasComments: Yes
