Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 )
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls ...................................................................... Patch Set 1: > Thanks! I'll update the logic so BeginCommit calls after we're > COMMITTED to be OK. Cool! I wasn't sure it would be the right thing to do when quickly looking into the code. But after some consideration I agree it make sense to return OK on BeginCommit() even if state of the transaction is COMMITED, so the behavior is no longer time-sensitive as of now (we now accept such a call if the state COMMIT_IN_PROGRESS, but reject if the state is COMMITTED). -- To view, visit http://gerrit.cloudera.org:8080/17069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486 Gerrit-Change-Number: 17069 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Feb 2021 19:18:34 +0000 Gerrit-HasComments: No
