Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17063 )
Change subject: [test] Start using GTEST_SKIP where applicable ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17063/2//COMMIT_MSG Commit Message: PS2: I see there are similar usages of the AllowSlowTests() function not covered by this patch at least in the following tests: * TYPED_TEST(BlockManagerTest, CloseManyBlocksTest) in block_manager-test.cc * TEST_F(AlterTableTest, TestRestartTSDuringAlter) in alter_table-test.cc * TEST_F(ConsensusPeerHealthStatusITest, TestPeerHealthStatusTransitions) in conensus_peer_health_status-itest.cc * TEST_F(CreateTableITest, TestCreateTableWithDeadTServers) in create-table-itest.cc * etc. Is it intentional not to update those? http://gerrit.cloudera.org:8080/#/c/17063/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17063/2/src/kudu/client/client-test.cc@5247 PS2, Line 5247: if (!AllowSlowTests()) { What about this one? -- To view, visit http://gerrit.cloudera.org:8080/17063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4466bdde3965921d527131e76ad221643ff05705 Gerrit-Change-Number: 17063 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 17 Feb 2021 00:26:13 +0000 Gerrit-HasComments: Yes
