Hello Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17089
to look at the new patch set (#2).
Change subject: [test] Fix flakiness with detecting a master in
FAILED_UNRECOVERABLE state
......................................................................
[test] Fix flakiness with detecting a master in FAILED_UNRECOVERABLE state
Observed one test failure on the flakiness dashboard in the
dynamic_multi_master test where system catalog WAL is expected to be
GC'ed and hence new master can't be caught up from WAL which should
result in the new master going to FAILED_UNRECOVERABLE state.
However the new master gets caught up from WAL and is in HEALTHY
state.
Expected: consensus::HealthReportPB::FAILED_UNRECOVERABLE
Which is: 2
To be equal to: peer.health_report().overall_health()
Which is: 1
This is because the check for system catalog WAL was made against
master index 0 which may not be the leader master and that's what
happened in case of the test failure.
The fix makes the GC count check against all masters as master
leadership could change.
This change also includes another place where master index 0 was used
and it'd be good to explicitly use the leader index to future-proof
it in case order of validation is changed.
Change-Id: Id6017f1601eaed22be28c8a5babd6e35e93b1d2e
---
M src/kudu/master/dynamic_multi_master-test.cc
1 file changed, 40 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/17089/2
--
To view, visit http://gerrit.cloudera.org:8080/17089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6017f1601eaed22be28c8a5babd6e35e93b1d2e
Gerrit-Change-Number: 17089
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
