Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17090 )
Change subject: KUDU-2671: Adds compatibility for per range hash schemas with unbounded ranges. ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/17090/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17090/2/src/kudu/common/partition.cc@521 PS2, Line 521: r (int j = 0; j < partitions->size(); j++) { : Partition& partition = (*partitions)[j]; : // Finds the first zero-valued bucket from the end and truncates the partition key : // starting from that bucket onwards for zero-valued buckets. : if (partition.range_key_start().empty()) { : for (int i = static_cast<int>(partition.hash_buckets().size()) - 1; i >= 0; i--) { : if (partition.hash_buckets()[i] != 0) { : > nit: maybe comment Done http://gerrit.cloudera.org:8080/#/c/17090/2/src/kudu/common/partition.cc@531 PS2, Line 531: } : } > nit: maybe comment Done http://gerrit.cloudera.org:8080/#/c/17090/2/src/kudu/common/partition.cc@533 PS2, Line 533: tarting from the > Use a pointer, otherwise we're making a copies here. Done http://gerrit.cloudera.org:8080/#/c/17090/2/src/kudu/common/partition.cc@537 PS2, Line 537: > nit: how about calling this 'schemas_idx_by_partition_idx' or something? Or Done -- To view, visit http://gerrit.cloudera.org:8080/17090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f6c709e211359b04f7597af5f670c787bda7481 Gerrit-Change-Number: 17090 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Feb 2021 01:44:13 +0000 Gerrit-HasComments: Yes
