Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17022 )
Change subject: KUDU-2612: allow aborting after beginning to commit ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17022/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17022/3//COMMIT_MSG@10 PS3, Line 10: FINALIZE_IN_PROGRESS state to serve as an intermediate step between : COMMIT_IN_PROGRESS Can you briefly describe the difference between COMMIT_IN_PROGRESS and FINALIZE_IN_PROGRESS. e.g. COMMIT_IN_PROGRESS covers the process from BeginCommit to Finalize. And FINALIZE_IN_PROGRESS covers the process from Finalize to Committed? Also for my own understanding once in FINALIZE_IN_PROGRESS state the transaction cannot be aborted? http://gerrit.cloudera.org:8080/#/c/17022/3/src/kudu/transactions/txn_status_manager.h File src/kudu/transactions/txn_status_manager.h: http://gerrit.cloudera.org:8080/#/c/17022/3/src/kudu/transactions/txn_status_manager.h@155 PS3, Line 155: DCHECK_EQ(TxnStatePB::OPEN, abort_txn_); I don't quite understand why not check TxnStatePB::ABORT_IN_PROGRESS instead of OPEN, Since ABORT_IN_PROGRESS is the previous state of Aborted? -- To view, visit http://gerrit.cloudera.org:8080/17022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b6596df2db5601f7e17e528ad6dc68057b67f8 Gerrit-Change-Number: 17022 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Feb 2021 19:57:09 +0000 Gerrit-HasComments: Yes
