Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17120 )
Change subject: [client-test] added WriteWhileRestartingMultipleTabletServers ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17120/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17120/1/src/kudu/client/client-test.cc@7912 PS1, Line 7912: for (auto mode : {KuduScanner::READ_LATEST, KuduScanner::READ_YOUR_WRITES}) { At first I thought this could lead to flakiness because there could be a leadership change in between writing and reading, and we could end up scanning a stale leader. I don't think that's actually the case though, since if we're scanning a "stale follower", it must have changed leadership after having written all rows successfully, since we're using the same client that wrote the rows. -- To view, visit http://gerrit.cloudera.org:8080/17120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95d1456dea2e6e2bb7d8b0c5d05e95798098710d Gerrit-Change-Number: 17120 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 01:57:22 +0000 Gerrit-HasComments: Yes
