Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17128 )

Change subject: [client-test] more robust TestRetrieveAuthzTokenInParallel
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17128/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/17128/1/src/kudu/client/client-test.cc@6912
PS1, Line 6912: kNumCPUs
nit: why not keep the name kThreads? The rest of the test seems to care more 
about the number of threads executing rather than about the hardware.


http://gerrit.cloudera.org:8080/#/c/17128/1/src/kudu/client/client-test.cc@6913
PS1, Line 6913: >
Should be <



--
To view, visit http://gerrit.cloudera.org:8080/17128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afa5ae72ccb96a218b6c6ff026ad88a70dea4f7
Gerrit-Change-Number: 17128
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Feb 2021 04:24:28 +0000
Gerrit-HasComments: Yes

Reply via email to