Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17161 )
Change subject: KUDU-2671: No-op ClientServerMapping if only one schema exists. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17161/2/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/17161/2/src/kudu/common/row_operations.cc@682 PS2, Line 682: RETURN_NOT_OK(client_schema_->GetProjectionMapping(*tablet_schema_, : client_schema_ == tablet_schema_, : &mapping)); nit: how about instead we just put this into the if block below? Then we wouldn't have to touch GetProjectionMapping() at all -- To view, visit http://gerrit.cloudera.org:8080/17161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I836f157201509a9b38a3ad42d653236f240dda5e Gerrit-Change-Number: 17161 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Mar 2021 07:10:57 +0000 Gerrit-HasComments: Yes
