Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17190 )
Change subject: [TlsSocket] clear error queue in Recv on SSL_RECEIVED_SHUTDOWN ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17190/1/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/17190/1/src/kudu/security/tls_socket.cc@199 PS1, Line 199: char buf[256]; > Shouldn't we use GetSSLErrorDescription() instead of this? We use this else Good point: indeed, GetOpenSSLErrors() seems more appropriate here. -- To view, visit http://gerrit.cloudera.org:8080/17190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie64456b61b797085d1ec6df76a8b2dfeca9860c9 Gerrit-Change-Number: 17190 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Mar 2021 15:03:53 +0000 Gerrit-HasComments: Yes
