Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17022 )
Change subject: KUDU-2612: allow aborting after beginning to commit ...................................................................... Patch Set 8: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/17022/5/src/kudu/integration-tests/txn_commit-itest.cc File src/kudu/integration-tests/txn_commit-itest.cc: http://gerrit.cloudera.org:8080/#/c/17022/5/src/kudu/integration-tests/txn_commit-itest.cc@764 PS5, Line 764: const int expected_rows = initial_row_count_ + kNumRowsPerTxn * num_committed_txns; > Done This item is marked "Done" but I don't see the change in PS8 to make sure all transactions reached either committed or aborted state. Do I miss anything? http://gerrit.cloudera.org:8080/#/c/17022/5/src/kudu/integration-tests/txn_commit-itest.cc@838 PS5, Line 838: shared_ptr<KuduTransaction> txn; : shared_ptr<KuduSession> txn > Indeed, the injected latency is defined at L833 Whoops -- I missed the setting for the flag. Thanks for pointing that out. http://gerrit.cloudera.org:8080/#/c/17022/8/src/kudu/transactions/txn_status_manager.h File src/kudu/transactions/txn_status_manager.h: http://gerrit.cloudera.org:8080/#/c/17022/8/src/kudu/transactions/txn_status_manager.h@160 PS8, Line 160: a nit: an ? -- To view, visit http://gerrit.cloudera.org:8080/17022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b6596df2db5601f7e17e528ad6dc68057b67f8 Gerrit-Change-Number: 17022 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Mar 2021 05:57:07 +0000 Gerrit-HasComments: Yes
