Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17266 )
Change subject: [mini-cluster] Refactor to expose flags of ExternalMaster ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17266/1/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/17266/1/src/kudu/mini-cluster/external_mini_cluster.h@736 PS1, Line 736: / Get flags that are exclusive to ExternalMaster on starting it for the first time. nit: it isn't quite clear to me based on this description how this relates to GetCommonFlags. Could you clarify, e.g. by mentioning whether GetCommonFlags() is a subset of GetCommonStartFlags() or vice versa? Or is the "restart" notion the important piece here? http://gerrit.cloudera.org:8080/#/c/17266/1/src/kudu/mini-cluster/external_mini_cluster.h@737 PS1, Line 737: rpc_bind_addr nit: document the argument? -- To view, visit http://gerrit.cloudera.org:8080/17266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeff3b0d6bc0021ce2aa50e8022542fb32250e07 Gerrit-Change-Number: 17266 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Apr 2021 18:33:21 +0000 Gerrit-HasComments: Yes
