Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17297 )
Change subject: KUDU-2612: Java client failover scenarios for TxnManager ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java: http://gerrit.cloudera.org:8080/#/c/17297/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java@852 PS1, Line 852: harness.startAllMasterServers(); > The other test scenario uses harness.killLeaderMasterServer() and it works We discussed this in person and I missed that the above case kills the leader master and leaves it dead, which does test what I mention here. I'm all for spicier tests, but I'm also fine with this test as is. -- To view, visit http://gerrit.cloudera.org:8080/17297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c7d73ce4a74d426286facbf02dff6e48b46a7c0 Gerrit-Change-Number: 17297 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 09 Apr 2021 22:35:16 +0000 Gerrit-HasComments: Yes
