Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17266 )
Change subject: [mini-cluster] Refactor to expose flags of ExternalMaster ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17266/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17266/1/src/kudu/mini-cluster/external_mini_cluster.cc@1493 PS1, Line 1493: flags.emplace_back("--tsk_num_rsa_bits=512"); : } > With static initialization using ternary operator, kFlags will be initializ Not sure how that's relevant, but thank you for the explanation. I don't see how the prior implementation could have the bug you mentioned, but at least the code of this function in PS4 looks good to me now. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/17266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeff3b0d6bc0021ce2aa50e8022542fb32250e07 Gerrit-Change-Number: 17266 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 15 Apr 2021 03:09:40 +0000 Gerrit-HasComments: Yes
