Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Management of per-table level limit ...................................................................... Patch Set 34: (11 comments) http://gerrit.cloudera.org:8080/#/c/17273/32//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17273/32//COMMIT_MSG@7 PS32, Line 7: Management of per-table level li > In English 'quota' has semantics of 'a fixed share of something that a pers Ack http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.h@274 PS32, Line 274: rea > have Tables which save streaming data should have a write limit, typically, Kudu as a flink sinker (https://docs.cloudera.com/csa/1.2.0/datastream-connectors/topics/csa-kudu-sink.html) is such an example. http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@340 PS32, Line 340: experimental > nit: could this flag tagged with the 'runtime' tag as well? Sure http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@344 PS32, Line 344: ric_limits< > For clarity, it would be great to specify the size unit (bytes, KBytes, KiB in bytes http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@349 PS32, Line 349: > What table? It would be great if you could add more details for the descri Done http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@2886 PS32, Line 2886: rn S > It would be great to add a comment to explain Done http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@2888 PS32, Line 2888: ; > nit: or a super user Done http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@2914 PS32, Line 2914: > What if req.disk_size_limit() == -2 or other negative number but -1? I did Good catch. I'll add it. http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@2921 PS32, Line 2921: > ditto for the row count limit: would it be OK if the value here was -2 and Fixed it. http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@3425 PS32, Line 3425: resp->set_disk_size_limit(l.data().pb.table_disk_size_li > It's better to release the lock when performing IO such as logging at line Done http://gerrit.cloudera.org:8080/#/c/17273/32/src/kudu/master/catalog_manager.cc@3447 PS32, Line 3447: le_disk_size_limit = table_lo > nit: The writing into the table is disallowed. Done -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 34 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 03 May 2021 11:57:14 +0000 Gerrit-HasComments: Yes
