Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17971 )
Change subject: KUDU-3295: Fix the number of replicas does not equal the number of servers ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17971/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/17971/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2374 PS2, Line 2374: dnsFailedServers.add(addresses.get(0).getHost()); > nit: could you add a comment explaining that resolveTS() only resolves the Ack http://gerrit.cloudera.org:8080/#/c/17971/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2385 PS2, Line 2385: dnsFailedServers.contains(tsHost) || tsHost == null > optimization nit (here and below at line 2407): should the null check go fi Ack http://gerrit.cloudera.org:8080/#/c/17971/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2417 PS2, Line 2417: if (!lookupExceptions.isEmpty() && : lookupExceptions.size() == tabletPb.getInternedReplicasCount()) { : Status statusIOE = Status.IOError("Couldn't find any valid locations, exceptions: " + : lookupExceptions); : throw new NonRecoverableException(statusIOE); : } : > +1 Do you have any suggestion here or anything this patch can help? -- To view, visit http://gerrit.cloudera.org:8080/17971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d2e7d49d234e41e66e9c367e061fb7da32e9b47 Gerrit-Change-Number: 17971 Gerrit-PatchSet: 2 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Oct 2021 01:29:44 +0000 Gerrit-HasComments: Yes
