Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18169 )
Change subject: [tool] fix a command bug, cmd: kudu wal dump ... ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18169/2/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/18169/2/src/kudu/tools/tool_action_common.cc@357 PS2, Line 357: CHECK(replicate.has_alter_schema_request()); Would it be better to return an error status instead of core? http://gerrit.cloudera.org:8080/#/c/18169/2/src/kudu/tools/tool_action_common.cc@358 PS2, Line 358: Schema schema; Why not use tablet_schema directly? http://gerrit.cloudera.org:8080/#/c/18169/2/src/kudu/tools/tool_action_common.cc@359 PS2, Line 359: SchemaFromPB(replicate.alter_schema_request().schema(), &schema); Return the error status of SchemaFromPB? -- To view, visit http://gerrit.cloudera.org:8080/18169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27acc71597d038cafbbe687117bddb1ce16576c0 Gerrit-Change-Number: 18169 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 28 Jan 2022 16:15:41 +0000 Gerrit-HasComments: Yes
