Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18182 )
Change subject: [clang-tidy] add modernize-{deprecated-headers,use-override}
......................................................................
[clang-tidy] add modernize-{deprecated-headers,use-override}
This patch adds modernize-deprecated-headers [1] and
modernize-use-override [2] checks for clang-tidy.
The former helps with changing the C-style headers into C++ ones: that
complements the IWYU functionality since the currently used IWYU version
suggests adding C-style headers, not C++ ones, and it's not clear what's
the timeline for addressing that.
The latter helps to remove extra 'virtual' keywords: I saw that in
a few recent patches posted for review, so I thought it would be nice
to automate catching those nits.
[1]
https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html
[2]
https://releases.llvm.org/9.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-use-override.html
Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Reviewed-on: http://gerrit.cloudera.org:8080/18182
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
---
M src/kudu/.clang-tidy
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e8e2e19b185350969a2945326a7193d1e8f60d
Gerrit-Change-Number: 18182
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
