Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18269 )
Change subject: [tests] harmonize assertions on the expected status
......................................................................
[tests] harmonize assertions on the expected status
I was trying to understand why a test scenario from security-itest
failed in one of gerrit pre-commit runs and found that it would be
great to know the actual vs the expected type of the status when an
assertion of type ASSERT_{FALSE,TRUE}(s.IsXxx()) triggers.
This patch updates the corresponding call sites of ASSERT_{FALSE,TRUE}
in the code of that and other tests to provide such information for
easier troubleshooting and debugging in future.
Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Reviewed-on: http://gerrit.cloudera.org:8080/18269
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/fs/data_dirs-test.cc
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master-test.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/ops/op_tracker-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/txn_participant-test.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/net/socket-test.cc
M src/kudu/util/oid_generator-test.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/yamlreader-test.cc
42 files changed, 121 insertions(+), 120 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I09cba638a5328fc57cc1ca70196bab42f09569b4
Gerrit-Change-Number: 18269
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com>
