Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18288 )
Change subject: [thirdparty] build curl without brotli ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > > Curious, why was this problematic before? Or is this more a hygiene > > > improvement, build only what we use? > > > > This becomes an issue only when brotli is installed on the build machine. > > This becomes a problem only for RELEASE builds (statically linked > > binaries). In case of dynamically linked binaries, that's not visible. > > > > Did you happen to have broli compression libraries on your laptop or build > > machine discovered by standard means? If so, try build RELEASE build -- > > I'm curious whether it's something specific to my environment, by from the > > configuration script I can see that it has --with-broli by default. > > Ah, I haven't built RELEASE binaries in some time. I'll try that out. Indeed, this led to issues for me too. Thanks for the fix! -- To view, visit http://gerrit.cloudera.org:8080/18288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14ef696302cc1653f3efd6dba5714ce3927c1d20 Gerrit-Change-Number: 18288 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Mar 2022 23:51:45 +0000 Gerrit-HasComments: No
