Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18374 )
Change subject: [tool] Add tool to copy replica from local filesystem ...................................................................... Patch Set 9: (11 comments) http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tools/kudu-tool-test.cc@7886 PS8, Line 7886: string tablet_id; > warning: multiple declarations in a single statement reduces readability [r Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tools/kudu-tool-test.cc@7904 PS8, Line 7904: } > warning: multiple declarations in a single statement reduces readability [r Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tools/kudu-tool-test.cc@7922 PS8, Line 7922: > warning: multiple declarations in a single statement reduces readability [r Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h@110 PS8, Line 110: virtual Status Start(const HostPort& /*copy_source_addr*/, > warning: parameter 'copy_source_addr' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h@111 PS8, Line 111: scoped_refptr<tablet::TabletMetadata>* /*meta*/) { > warning: parameter 'meta' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h@116 PS8, Line 116: virtual Status Start(const std::string& /*tablet_id*/, > warning: parameter 'tablet_id' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h@117 PS8, Line 117: scoped_refptr<tablet::TabletMetadata>* /*meta*/) { > warning: parameter 'meta' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_client.h@330 PS8, Line 330: ~RemoteTabletCopyClient() override; > warning: annotate this function with 'override' or (rarely) 'final' [modern Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_service.cc File src/kudu/tserver/tablet_copy_service.cc: http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_service.cc@269 PS8, Line 269: RPC_RETURN_NOT_OK(FindSessionUnlocked(session_id, &app_error, &session), > warning: 2nd function call argument is an uninitialized value [clang-analyz Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_service.cc@331 PS8, Line 331: RPC_RETURN_NOT_OK(DoEndTabletCopySessionUnlocked(req->session_id(), &app_error), > warning: 2nd function call argument is an uninitialized value [clang-analyz Done http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/18374/8/src/kudu/tserver/tablet_copy_source_session.cc@322 PS8, Line 322: CHECK(file_info); > warning: Called C++ object pointer is null [clang-analyzer-core.CallAndMess Done -- To view, visit http://gerrit.cloudera.org:8080/18374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dcafeaad900b66f297914760c54dba887874e95 Gerrit-Change-Number: 18374 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Tue, 12 Apr 2022 16:34:49 +0000 Gerrit-HasComments: Yes
