Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18429 )
Change subject: [unit test] Fix a semantics problem ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks good! Consider updating the commit message to make it a bit more concise. http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@7 PS1, Line 7: [unit test] Fix a semantics problem nit: how about [disk_failure-itest] fix premature return from AllowRecovery() http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@9 PS1, Line 9: When I do some tests (the work is doing), I found AllowRecovery() : maybe should fix. : : According to semantics, I think AllowRecovery() should enable all : tservers recovery. nit: how about Fixed a premature return from the AllowRecovery() utility function. Prior to this fix, the error injection flags were reset only for the first table server upon call to AllowRecovery(). -- To view, visit http://gerrit.cloudera.org:8080/18429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113 Gerrit-Change-Number: 18429 Gerrit-PatchSet: 1 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Apr 2022 00:36:07 +0000 Gerrit-HasComments: Yes
