Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18426 )
Change subject: [unit test] KUDU-3360 Fix DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc File src/kudu/integration-tests/write_limit-itest.cc: http://gerrit.cloudera.org:8080/#/c/18426/1/src/kudu/integration-tests/write_limit-itest.cc@429 PS1, Line 429: ASSERT_OK(SetupClient(kUser)); > Could you explain why it failed when row_limit is kRowCountLimit? As I understand, the issue was two fold: 1) failure to hit the disk space limit because of compactions and GC going on right after inserting the rows 2) failure to stop hitting the disk space limit because some data hasn't been compacted yet After the update with patch https://github.com/apache/kudu/commit/c146454dfa6a840b79a33f16bc2df6a3b6c93600 , only the first issue left as I can see: src/kudu/integration-tests/write_limit-itest.cc:429: Failure Expected: TestSizeLimit() doesn't generate new fatal failures in the current thread. Actual: it does. With more rows inserted, the compaction, GC, and other jazz isn't able to shrink the amount of data fast enough even in case of some scheduling anomalies. -- To view, visit http://gerrit.cloudera.org:8080/18426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide7255de177999dcf646a4eda63351e76de2b1cf Gerrit-Change-Number: 18426 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 28 Apr 2022 19:22:49 +0000 Gerrit-HasComments: Yes
