Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18448 )
Change subject: [tools] use thread pool for 'kudu local_replica copy_from_local' ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@476 PS5, Line 476: // Prepare to check copy progress. nit: What about "Protects 'copying_replicas' and 'failed_tablet_ids'"? http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@486 PS5, Line 486: continue nit: Is this needed? http://gerrit.cloudera.org:8080/#/c/18448/5/src/kudu/tools/tool_action_local_replica.cc@518 PS5, Line 518: if (ContainsKey(failed_tablet_ids, tablet_id)) continue; nit: What about removing non-exist tablets from `tablet_ids_to_copy` in advance? -- To view, visit http://gerrit.cloudera.org:8080/18448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4de49e948cc1a686db5e1bf424470ca9e800ee36 Gerrit-Change-Number: 18448 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Fri, 29 Apr 2022 09:38:39 +0000 Gerrit-HasComments: Yes
