Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18460 )
Change subject: [thirdparty] Upgrade glog to 0.6.0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18460/2//COMMIT_MSG@18 PS2, Line 18: had to be modified Do you mind explaining the reason for the modification? BTW, is it still buildable on aarch64 after the modification? http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch File thirdparty/patches/glog-make-internals-visible.patch: http://gerrit.cloudera.org:8080/#/c/18460/2/thirdparty/patches/glog-make-internals-visible.patch@8 PS2, Line 8: > nit: whitespace That's a patch file, so whitespace in a must for the unified diff format here. -- To view, visit http://gerrit.cloudera.org:8080/18460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21abd1749fdfdcde412f5a2ca2245c42da20d4f3 Gerrit-Change-Number: 18460 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Khazar Mammadli <mammadli.kha...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Apr 2022 16:49:11 +0000 Gerrit-HasComments: Yes
