Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18609 )
Change subject: remove zlib dependency in llvm-iwyu as it affected ubuntu build ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18609/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18609/1//COMMIT_MSG@7 PS1, Line 7: remove zlib dependency in llvm-iwyu Does it make sense to update this even for the current version of LLVM or with current version IWYU would be broken once this dependency is removed? http://gerrit.cloudera.org:8080/#/c/18609/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/18609/1/thirdparty/build-definitions.sh@a303 PS1, Line 303: Just to double-check: I guess you've verified that IWYU is working with this change, right (something like running 'make iwyu' target)? -- To view, visit http://gerrit.cloudera.org:8080/18609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31cb3a3cb2173bf8af3c6ad04f2a5ac2e1e09ad8 Gerrit-Change-Number: 18609 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jun 2022 14:32:25 +0000 Gerrit-HasComments: Yes
