Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 )
Change subject: [Flag] Check flags consistency when setting a flag ...................................................................... Patch Set 6: (10 comments) > Patch Set 4: > > (11 comments) http://gerrit.cloudera.org:8080/#/c/19237/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19237/4//COMMIT_MSG@14 PS4, Line 14: > unavailable Done http://gerrit.cloudera.org:8080/#/c/19237/4//COMMIT_MSG@18 PS4, Line 18: flag. Firs > consistency Done http://gerrit.cloudera.org:8080/#/c/19237/4//COMMIT_MSG@26 PS4, Line 26: ey_fi > should Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/generic_service.cc@156 PS4, Line 156: > nit: flags Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/generic_service.cc@162 PS4, Line 162: > nit: rolled back Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/generic_service.cc@171 PS4, Line 171: L > nit: adding this extra scope isn't necessary, so maybe remove the curly bra Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/server_base.proto File src/kudu/server/server_base.proto: http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/server_base.proto@80 PS4, Line 80: hen a flag > ... the flag is set. Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/server_base.proto@80 PS4, Line 80: for consist > for consistency Done http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/server/server_base.proto@81 PS4, Line 81: run_consistency_check > I think it makes sense to rename this to have a 'positive' semantics instea Yes, I agree. http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/19237/4/src/kudu/util/flags.cc@444 PS4, Line 444: return true; > I guess this isn't needed since every validator prints detailed message on Done -- To view, visit http://gerrit.cloudera.org:8080/19237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e6e37e0f4e72a2cc3d2316248961315f1757ebc Gerrit-Change-Number: 19237 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 10:39:47 +0000 Gerrit-HasComments: Yes
