Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19246 )
Change subject: WIP [compact] Increase chances of compaction for large number deltas ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/19246/1/src/kudu/tablet/tablet.cc@2482 PS1, Line 2482: workload_score = std::min(FLAGS_workload_score_upper_bound, : tablet_bytes / max_limit_deltas_size); > That's a good point. I almost forgot about it even after pointed this out We also don't want to starve DMS flushes. There seems to be this test(TestDontStarveDMSWhileUnderMemoryPressure ) failing because DMS flush didn't happens for more than 30 seconds. I suspect that compaction op score is almost always beating DMS flush in this test. I will need to check though. I am currently running the two set of tests - one with this change and second without this change. And compare the number of times Compaction op and other ran. That should give a fair idea on whether this is causing starvation of certain ops that used to get scheduled with low perf score before. -- To view, visit http://gerrit.cloudera.org:8080/19246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2199ae3b777e75b15b60d8ad818cc6adc4f5fa3b Gerrit-Change-Number: 19246 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Nov 2022 15:05:54 +0000 Gerrit-HasComments: Yes
