Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19232 )
Change subject: Follow-up on OpenSSL 3 FIPS_mode removal ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19232/5/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/19232/5/src/kudu/server/webserver-test.cc@69 PS5, Line 69: // FIPS_mode is removed from OpenSSL3 for test purposes, a fake one is created and : // set to disabled. : #if OPENSSL_VERSION_NUMBER >= 0x30000000L : int FIPS_mode() { return 0; } : #endif > Yes they, do because in multiple tests in webserver-test.cc FIPS_mode funct OK, thanks for clarifying on this: it seems I missed checking webserver-test.cc for the usage of FIPS_mode(). Yes, I'd rather vote for the approach you pointed at, but since it seems this patch is just a temporary fix before properly addressing the detection of FIPS mode in OpenSSL3, I guess it's good enough. So, this looks good enough to me as is. -- To view, visit http://gerrit.cloudera.org:8080/19232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib67d6e6c28085ca61456c26a759c89ecdffb0b4a Gerrit-Change-Number: 19232 Gerrit-PatchSet: 5 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 05:48:52 +0000 Gerrit-HasComments: Yes
