Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19281 )
Change subject: KUDU-3406 memory budgeting for CompactRowSetsOp ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19281/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19281/7//COMMIT_MSG@13 PS7, Line 13: > nit: Extra Space I add those extra spaces intentionally for better readability in the commit messages: two spaces after every full stop unless the next sentence starts with a new line. You could see that throughout all my commit messages. http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/19281/6/src/kudu/tablet/compaction_policy.cc@170 PS6, Line 170: pplies only when configured so. > Right, I guess the question even if we have the metrics available is there Ah, I see -- it seems I misunderstood your original comment. I don't see a scenario where I'd think to continue using the preset factor when more accurate stats collected via the metrics are available. The only case might be if the metrics aren't relevant. It could happen if the accounting for the allocated memory had a bug or the statistics were collected on not-so-relevant data. The latter is supposed to be addressed by tweaking the --rowset_compaction_estimate_min_deltas_size_mb flag once the metrics are reset (upon restart?). As for the former, it's hard to tell how to choose a relevant factor at all in that case (maybe, by postmortem analysis of the peak memory usage and the size of the delta stores provided by the 'kudu fs list' CLI tool?) However, I might be missing something here. To address your concern, I added an extra flag to enforce using the preset factor if so desired. -- To view, visit http://gerrit.cloudera.org:8080/19281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c171284944831e95c45a993d85fbefe89048cf Gerrit-Change-Number: 19281 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Comment-Date: Mon, 19 Dec 2022 22:35:16 +0000 Gerrit-HasComments: Yes
