Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica tmeta delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc@105 PS3, Line 105: DEFINE_bool(backup_metadata, false, > > It's safer using default 'true' and use 'enable_adding_orphaned_blocks' f The CLI command is very useful for the replicaion_factor = 1, and the only one tablet replica is corrupted. It seems the CLI command should work at FLAGS_backup_metadata false and FLAGS_enable_adding_orphaned_blocks true, and after running it. And it is impossible to rollback. Hence, serious problems may happen by incautious administrators. In order to avoid the serious problems, backup metadata/data may needed. But it's a little difficult because the deleting operation can not avoid some dangerous. At the same time, the CLI command face to a tserver, if a tablet has 3 replicas, it should keep writing stop and operate at 3 tservers. Maybe we should add some describe words or some forbidden condition later. -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 02:47:53 +0000 Gerrit-HasComments: Yes
