Hello Mahesh Reddy, Marton Greber, Alexey Serbin, Kudu Jenkins, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19097 to look at the new patch set (#14). Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... KUDU-1945 Auto-Incrementing Column This patch adds a new column specification named auto_incrementing. The ColumnSchema of this new column is INT64 and not UINT64 as impala doesn't support UINT64. These columns are populated on the server side with a monotonically increasing counter. This counter is local to every tablet i.e. each tablet has a separate auto incrementing counter. This is a step towards having tables with non unique primary keys or in case of tables with just one tablet, a table wide unique key. Upon receiving a write request the leader replica: 1. Fills in the replicate message with the auto incrementing counter value for the first write op. 2. Populates the auto incrementing key into the rows being inserted during the prepare phase. 3. Sends out the replicate message with the auto incrementing counter and the original write request. The followers perform the same set of steps to populate the auto incrementing column. It also adds the c++ client side changes needed for basic writes and reads of this column to perform end-to-end tests. Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc --- M src/kudu/client/client-test.cc M src/kudu/client/client-unittest.cc M src/kudu/client/scan_configuration.cc M src/kudu/client/schema-internal.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/client/session-internal.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc M src/kudu/common/common.proto M src/kudu/common/generic_iterators-test.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partition-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/schema-test.cc M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/auto_incrementing-itest.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h A src/kudu/tablet/tablet_auto_incrementing-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server_authorization-test.cc M src/kudu/tserver/tserver.proto 38 files changed, 705 insertions(+), 69 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/19097/14 -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 14 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>