Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/client-unittest.cc File src/kudu/client/client-unittest.cc: http://gerrit.cloudera.org:8080/#/c/19272/19/src/kudu/client/client-unittest.cc@267 PS19, Line 267: > Could you also add a scenario where a schema with a INT64 column named "aut I think Column name 'auto_incrementing_id' should be reserved column name for Kudu engine. To avoid confusion, we should not allow user to add a column named as 'auto_incrementing_id' when creating table or alter table. Java client throw exception if user try to add a column named as 'auto_incrementing_id'. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 19 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 04:21:21 +0000 Gerrit-HasComments: Yes
