Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19407 )
Change subject: [web] add maintenance op statistics information at web pages for data_retained_bytes ...................................................................... Patch Set 4: (6 comments) > Patch Set 4: Code-Review+1 > > It would be nice if you could provide the screenshot for the maintenance > manager page and add the permanent link to the commit message. Thanks your advice, get it. I should study it. How to do this, is there any common way to do this? http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11 PS4, Line 11: showed > shown Done http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@11 PS4, Line 11: no the information > no such information Done http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: protobuf file > the protobuf file Done http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: variable > field Done http://gerrit.cloudera.org:8080/#/c/19407/4//COMMIT_MSG@13 PS4, Line 13: show it at web pages > ... updates the embedded web server to show the retained bytes for a mainte Done http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc File src/kudu/integration-tests/webserver-stress-itest.cc: http://gerrit.cloudera.org:8080/#/c/19407/4/src/kudu/integration-tests/webserver-stress-itest.cc@101 PS4, Line 101: #ifdef __linux__ > Would be great to add a comment to explain why having this extra check unde I think it again, it's not necessary to restrict os platform. So I remove it. -- To view, visit http://gerrit.cloudera.org:8080/19407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8f0307705d57cea48901102b170c88d73d8c2e Gerrit-Change-Number: 19407 Gerrit-PatchSet: 4 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 31 Jan 2023 06:40:00 +0000 Gerrit-HasComments: Yes
