Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18474 )
Change subject: jwt: expose MiniOidc to Kudu test binary ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@75 PS6, Line 75: invalid_key > It's better to keep consistent with CreateJwtPB to name it as valid_key? +1 Also, please follow the naming convention used in this file for other boolean fields: that should be something like 'is_xxx' http://gerrit.cloudera.org:8080/#/c/18474/6/src/kudu/tools/tool.proto@559 PS6, Line 559: valid_key > It's better to rename as valid_key_id Maybe, keep this consistent with naming of other boolean fields in the file and name this 'is_valid_key_id' or 'is_key_id_valid'? -- To view, visit http://gerrit.cloudera.org:8080/18474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397913fb5f1f2634b71b35f8c91f895b44e73be9 Gerrit-Change-Number: 18474 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <anjuw...@g.ucla.edu> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Feb 2023 03:46:43 +0000 Gerrit-HasComments: Yes
