Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19512 )
Change subject: [docs] Add release notes for 1.17.0 ...................................................................... Patch Set 3: (29 comments) Looks good for the most part, just some grammatical nits. http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@55 PS3, Line 55: ** The default value of tablet history retention time (controlled by `--tablet_history_max_age_sec` Should this go under the "Optimizations and Improvements" section? http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@56 PS3, Line 56: 5 minutes, since masters always scan data at : the latest available snapshot, keeping long history of the system tablet doesn't make much sense. nit: Change to "5 minutes. It's no longer necessary to keep such a long history of the system tablet since masters always scan data at the latest available snapshot". http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@76 PS3, Line 76: tables, it's now possible to alter a table and : add a new range partition with custom hash sub-partitioning. nit: Change to "tables. It's now possible to add ranges with their own unique hash schema independent of the table wide hash schema. This can be done at table creation time and or while altering the table." http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@87 PS3, Line 87: tablet nit: add comma after "tablet" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@87 PS3, Line 87: counter, the nit: Break up sentence, change to "counter. The" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@105 PS3, Line 105: meaning that nit: remove "meaning that" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@110 PS3, Line 110: (see link:https://issues.apache.org/jira/browse/KUDU-2670[KUDU-2670]). If dealing with the C++ client, KUDU-3393 is more accurate as KUDU-2670 deals with Java client and server parts. http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@112 PS3, Line 112: Java and C++ nit: switch order to "C++ and Java", corresponds to Jira links. http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@236 PS3, Line 236: of nit: change to "where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@237 PS3, Line 237: , nit: remove comma http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@238 PS3, Line 238: GCed Is the tablet only GCed if it was created before Kudu 1.10? Maybe put a period after "compacted" and put the GCed information in a separate sentence. http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@239 PS3, Line 239: accurating What does this mean? http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@242 PS3, Line 242: of nit: change to "where the" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@244 PS3, Line 244: of nit: change to "in the" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@244 PS3, Line 244: server nit: change to "server that is" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@247 PS3, Line 247: of C++ client nit: change to "in the C++ client where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@249 PS3, Line 249: of C++ client’ nit: change to "in the C++ client where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@251 PS3, Line 251: of Java client nit: change to "in the Java client where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@253 PS3, Line 253: of Java client's nit: change to "in the Java client where the" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@256 PS3, Line 256: that Java client nit: change to "in the Java client where it" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@258 PS3, Line 258: that nit: change to "in the Kudu HMS client where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@261 PS3, Line 261: of nit: change to "where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@263 PS3, Line 263: of nit: change to "where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@266 PS3, Line 266: that nit: change to "where" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@270 PS3, Line 270: of nit: change to "where the" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@270 PS3, Line 270: crash nit: change to "crashes" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@270 PS3, Line 270: flag nit: change to "flag is" http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@302 PS3, Line 302: vice-versa if not nit: change to "vice-versa. If not," http://gerrit.cloudera.org:8080/#/c/19512/3/docs/release_notes.adoc@308 PS3, Line 308: library if not nit: change to "library. If not," -- To view, visit http://gerrit.cloudera.org:8080/19512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I4381e7824dcf7f500165aa3af9dca09a86ac1dd9 Gerrit-Change-Number: 19512 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hongjiang Zhang <hongjizh...@ebay.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Khazar Mammadli <mammadli.kha...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: bsglz <18031...@qq.com> Gerrit-Reviewer: harinreddy <hnre...@us.ibm.com> Gerrit-Reviewer: yejiabao <yejia...@huawei.com> Gerrit-Reviewer: zhanghongbin <1079039...@qq.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Feb 2023 23:53:54 +0000 Gerrit-HasComments: Yes