Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19568 )
Change subject: [java] KUDU-3455 Reduce space complexity about pruning hash partitions for in-list predicate ...................................................................... Patch Set 6: (4 comments) > Patch Set 6: > > (4 comments) Very useful advices. Thank you. http://gerrit.cloudera.org:8080/#/c/19568/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19568/6//COMMIT_MSG@10 PS6, Line 10: it may cause java-client to go out of memory. > nit: Does the c++ client also have this issue? Maybe we should port this im Good remainder. I have checked it ( src/kudu/common/partition_pruner.cc#PartitionPruner::PruneHashComponent . The same problem exists in cpp-client, I'll fix it in another patch. http://gerrit.cloudera.org:8080/#/c/19568/6/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/19568/6/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java@665 PS6, Line 665: just for test. > Since this method is static and only for tests, maybe we can move it to the Good idea. DONE http://gerrit.cloudera.org:8080/#/c/19568/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/19568/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java@909 PS6, Line 909: Assert.assertTrue(v2CostMillis <= v1CostMillis / 10); > Is it always true? Perhaps the following log info would be enough and this Yes. I remove it. http://gerrit.cloudera.org:8080/#/c/19568/6/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java@920 PS6, Line 920: testInListHashPartitionPruningUsingLargeListOOM > Could you add a comment explaining what the test is for? Done -- To view, visit http://gerrit.cloudera.org:8080/19568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd6f213cb705e1b2a001562cc7cebe4164281723 Gerrit-Change-Number: 19568 Gerrit-PatchSet: 6 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:11:49 +0000 Gerrit-HasComments: Yes
