Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19611 )
Change subject: [ut] make a checking command of 'TestTServerListState' more meaningful ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19611/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19611/4/src/kudu/tools/kudu-tool-test.cc@4890 PS4, Line 4890: (int i = 1; i < kTServerNum; i++) { > nit: comments need update. Done http://gerrit.cloudera.org:8080/#/c/19611/4/src/kudu/tools/kudu-tool-test.cc@4891 PS4, Line 4891: // If a ts isn't requested, we shouldn't see its maintenance state. > If we set the ts number for 3 in line 4876, how about add a loop check in h Done -- To view, visit http://gerrit.cloudera.org:8080/19611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc3c16cba812eaaa8786cea37659fd5e9267fd3 Gerrit-Change-Number: 19611 Gerrit-PatchSet: 5 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:37:05 +0000 Gerrit-HasComments: Yes
