Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 )
Change subject: [master] exclude tservers in MAINTENANCE_MODE when leader rebalancing ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/19608/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19608/7//COMMIT_MSG@7 PS7, Line 7: exclude nit: Exclude http://gerrit.cloudera.org:8080/#/c/19608/7//COMMIT_MSG@11 PS7, Line 11: maintainning nit: being maintained http://gerrit.cloudera.org:8080/#/c/19608/7//COMMIT_MSG@11 PS7, Line 11: Leader : will serve many users' requests, so it's not reasonable that leader rebalancer : transfer some leader to it. We should exclude the tservers in MAINTENANCE_MODE. nit: Since it might be decommissioned, it doesn't make sense for the leader rebalancer to transfer a leader to a tserver in MAINTENANCE_MODE as leaders serve many users' requests. For this reason, we should exclude such tservers. http://gerrit.cloudera.org:8080/#/c/19608/7//COMMIT_MSG@15 PS7, Line 15: add nit: adds -- To view, visit http://gerrit.cloudera.org:8080/19608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f85a675e69fd02a62e2625881dad2ca5e27acd9 Gerrit-Change-Number: 19608 Gerrit-PatchSet: 7 Gerrit-Owner: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 23 Mar 2023 16:18:24 +0000 Gerrit-HasComments: Yes
