Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19653 )
Change subject: [client] Improve logging in client metacache ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM http://gerrit.cloudera.org:8080/#/c/19653/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19653/5//COMMIT_MSG@9 PS5, Line 9: As part for impala crashing issue Adding this impala's jira issue at this commit message would help us to understand this problem http://gerrit.cloudera.org:8080/#/c/19653/5/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/19653/5/src/kudu/client/meta_cache.cc@465 PS5, Line 465: if (leader) { : VLOG(1) << "Client copy of tablet " << tablet_->tablet_id() : << " is fresh, leader uuid " << leader->permanent_uuid(); : } else { : VLOG(1) << "Client copy of tablet " << tablet_->tablet_id() : << " is fresh (no leader)."; : } nit: whether using Substitute("Client copy of tablet $0 is fresh, leader uuid $1") is better? -- To view, visit http://gerrit.cloudera.org:8080/19653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a47f643307ef47a98b1d3481b4c03834fa239d4 Gerrit-Change-Number: 19653 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Thu, 30 Mar 2023 15:51:38 +0000 Gerrit-HasComments: Yes
