Hello Marton Greber, Tidy Bot, Alexey Serbin, Kudu Jenkins, Wenzhe Zhou, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19445 to look at the new patch set (#9). Change subject: KUDU-1945 Update auto incrementing counter during bootstrap ...................................................................... KUDU-1945 Update auto incrementing counter during bootstrap The auto incrementing counter would be reset to zero when the tablet is being initialized. It is essential to have the correct value of the counter. There are two cases: 1. WAL segments contain insert operations In this scenario the WAL segments are replayed and since each insert operation entry has auto incrementing counter which will be used for the insert operations present in that entry, as long as we have the latest insert operation entry in the WAL segments, the auto incrementing counter is populated correctly during bootstrap. 2. WAL segments do not contain insert operations In this case, we need to fetch the highest auto incrementing counter value present in the data which is already flushed and update the in-memory auto incrementing counter appropriately. This patch accomplishes this task. There are tests for the bootstrap scenarios where 1. We have no WAL segments with an INSERT OP containing the auto incrementing column value. We rely on the auto incrementing counter present in the data directories in this case. 2. We have no WAL segments with auto incrementing column value and all the rows of the table are deleted. We reset the auto incrementing counter in this case. 3. We have non committed replicate ops containing INSERT OPs with the auto incrementing column values. Manually tested the time taken to populate the auto incrementing counter: Columns - A Non Unique Primary Key column of type INT32 - 8 INT64 columns - 5 STRING columns Rows - 500k rows with data populated Time taken in populating the counter during bootstrap: Min - 235ms Max - 466ms Median - 312ms The total time spent boostrapping the tablet was between 18-25 seconds. Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 --- M src/kudu/integration-tests/auto_incrementing-itest.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tserver/tablet_server-test-base.h 4 files changed, 324 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/19445/9 -- To view, visit http://gerrit.cloudera.org:8080/19445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I61b305efd7d5a065a2976327567163956c0c2184 Gerrit-Change-Number: 19445 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>